Windows: Use a faster comparison when enumeration filter strings don't have wildcards #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilbaker
commented
Oct 2, 2018
| @@ -107,15 +109,31 @@ public string GetFilterString() | |||
| return this.filterString; | |||
| } | |||
|
|
|||
| private static bool NameMatchsNoWildcardFilter(string name, string filter) | |||
wilbaker
commented
Oct 2, 2018
|
|
||
| // Use our own enumerator to avoid having to dispose anything | ||
| private ProjectedFileInfoEnumerator fileInfoEnumerator; | ||
| private FileNamePatternMatcher patternMatcher; |
There was a problem hiding this comment.
Rename these to better names:
patternMatcher -> doesPatternMatch
wildcardPatternMatcher -> doesWildcardPatternMatch
sanoursa
approved these changes
Oct 2, 2018
nickgra
approved these changes
Oct 2, 2018
cgallred
reviewed
Oct 2, 2018
cgallred
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
ActiveEnumerationto usestring.Equalsrather thanUtils.IsFileNameMatchwhen the enumeration filter string does not have wildcards.Times with scenario provided by @kyle-rader